poz/modfetch
1
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

separator module #1

Merged
poz merged 5 commits from krizej/modfetch:sepmodule into master 2024-02-09 22:48:17 +01:00
Conversation 1 Commits 5 Files changed 1 +11 -11
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6104ed8199 - Show all commits

22
modules/sep.c
View file

@ -18,24 +18,24 @@ uint8_t version_patch(void) { return 0; }
const char *module_name(void) { return "sep"; }
static size_t length = 8;
static char *sep_char = "-";
static char *sep_char = (char[]){'-', '\0'};
krizej marked this conversation as resolved Outdated
poz commented 2024-02-09 21:50:32 +01:00
Outdated
Review
Copy link

implicitly cast the literal to char* because of a warning

modules/sep.c:21:25: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   21 | static char *sep_char = "-";
      |                         ^~~
implicitly cast the literal to `char*` because of a warning ``` modules/sep.c:21:25: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 21 | static char *sep_char = "-"; | ^~~ ```
krizej commented 2024-02-09 22:15:42 +01:00
Outdated
Review
Copy link

that produces basically the same warning but don't worry i've found a way :-)

that produces basically the same warning but don't worry i've found a way :-)
poz commented 2024-02-09 22:43:40 +01:00
Outdated
Review
Copy link

turn it back to "-"

turn it back to "-"
static size_t sep_char_length = 1;
void init(char **config) {
for(char *opt = *config; opt != NULL; opt = *++config) {
if(!strncmp(opt, "sep", 3)) {
for (char *opt = *config; opt != NULL; opt = *++config) {
krizej marked this conversation as resolved Outdated
poz commented 2024-02-09 21:47:09 +01:00
Outdated
Review
Copy link

for(...) -> for (...)
same for if

`for(...)` -> `for (...)` same for if
krizej commented 2024-02-09 22:15:13 +01:00
Outdated
Review
Copy link

why not functions though boy

why not functions though boy
poz commented 2024-02-09 22:40:08 +01:00
Outdated
Review
Copy link

functions are simply built different

functions are simply built different
krizej commented 2024-02-09 22:45:03 +01:00
Outdated
Review
Copy link

that is why their braces should be on a new line ;-)

that is why their braces should be on a new line ;-)
if (strncmp(opt, "sep", 3) == 0) {
krizej marked this conversation as resolved Outdated
poz commented 2024-02-09 21:46:04 +01:00
Outdated
Review
Copy link

instead of ! use == 0, same in the if below

instead of `!` use `== 0`, same in the if below
char *valstr = opt + 4; // skip 'sep='
long value = strtol(valstr, NULL, 10);
if(value >= 0) {
if (value >= 0) {
length = (size_t) value;
}
} else if(!strncmp(opt, "char", 4)) {
} else if (strncmp(opt, "char", 4) == 0) {
char *value = opt + 5; // skip 'char='
if(*value != 0) { // todo: see if there are any more characters that should be rejected
if (*value != 0) { // todo: see if there are any more characters that should be rejected
sep_char_length = strlen(value);
sep_char = malloc(sep_char_length + 1);
sep_char = malloc((sep_char_length + 1) * sizeof(*sep_char));
krizej marked this conversation as resolved Outdated
poz commented 2024-02-09 21:46:31 +01:00
Outdated
Review
Copy link

in all the mallocs do sizeof(type) even if the size is 1 byte

in all the mallocs do `sizeof(type)` even if the size is 1 byte
strncpy(sep_char, value, sep_char_length);
sep_char[sep_char_length] = '\0';
} else {
@ -48,16 +48,16 @@ void init(char **config) {
const char *get(void) {
char *ret;
if(sep_char == NULL) {
ret = malloc(1);
if (sep_char == NULL) {
ret = malloc(1 * sizeof(*ret));
*ret = 0;
return ret;
}
ret = malloc(length * sep_char_length + 1);
ret = malloc((length * sep_char_length + 1) * sizeof(*ret));
memset(ret, 0, length * sep_char_length + 1);
for(size_t i = 0; i < length; i++)
for (size_t i = 0; i < length; i++)
strncat(ret, sep_char, sep_char_length);
ret[length * sep_char_length] = '\0'; // just to be sure :-D